Warcraft 3 MODs

The problem is here:
format(mquery, 1023, "UPDATE `%s` SET playername='%s',xp=%d,skill1=%d,skill2=%d,skill3=%d,skill4=%d WHERE \
playerid='%s' AND race=%d AND xp<%d ", mysqltablename, playername, playerxp[id], p_skills[id][1], \
p_skills[id][2], p_skills[id][3], p_skills[id][4], playerid, p_skills ...

You should change the SELECT * FROM table, into actually telling what fields you want. It will lift a bit of load of the SQL-server.


#if MYSQL_ENABLED
if (returnrace)
{
if (get_cvar_num("mp_savebyname")==1)
format(mquery, 1023, "SELECT xp, race FROM `%s` WHERE playername='%s'",mysqltablename ...

Are you talking about ROUNDEND_SAVEALL or did I miss something? I've left that to the default and if I'm correct the default is enabled.

Looked at the code now and you are correct, it's a SQL statement error.

In write_xp_to_file() you have this. So if the players XP is lower than before it won't ...

I know it's a give XP command but I tried to remove XP from a user and it worked. However it never got save to the database, mysql, so when he rejoined he had all the original XP. We tried this three times without success. However if I gave him more XP it got saved without any problem.

Maybe adding ...

What about getting money for XP? Like if you give away 2000xp you would gain 2000 in money?

I could do it if you want. As you say it's not all that fun. But it's quite simple since it's just a question of copy and pasting.

12 if statements is not a lot of CPU cycles....

Checked a log and it had 159 say/team_say in it for a 20 minutes time span. That make a totalt of 1908 checks that is not needed. Even if they would be needed they could be executed at a lower level than checking them in a plugin.

Or am I wrong ...

Oh, I know how to do it. It simply hasn't been at the top of my priority list. This bit of code is some of the oldest in the plugin.

On the same note though, you won't truly save MUCH performance by splitting it up. AMXX will just register x more commands which all have to be checked against as a ...

Guess you already thought of it and my guess is that you are a busy man. Here goes anyway =)

Moving all the #if LANG_XXX out of the code would make the codebase smaller and more easy to maintain and also it would be easy to add more languages.

I think you could save alot of CPU cycles if the function check_say were splitted into one function for each thing. Right now you have 12 if that it goes thru ever time someone says something and that is bad in my opinion.

example

public plugin_init() {
register_clcmd("say /changerace","change ...

The variables for the team name is to short, teama[8],teamv[8].

L 08/11/2005 - 10:35:18: "CU|Anzero<5222><STEAM_0:1:7301782><CT>" killed "wizRd<5249><STEAM_0:1:1444758>< TERRORI >" with "Shadowstrike"

You should redefine them as teama[10], teamv[10] and also change the get_user_team in that ...